[PATCH] D21917: ThinLTO: Remove check for multiple modules before applying weak resolutions.

[Peter Collingbourne via llvm-commits]

pcc updated this revision to Diff 62991.
pcc added a comment.

- Refresh


http://reviews.llvm.org/D21917

Files:
  lib/LTO/LTO.cpp
  test/ThinLTO/X86/weak_resolution_single.ll

Index: test/ThinLTO/X86/weak_resolution_single.ll
===================================================================
--- /dev/null
+++ test/ThinLTO/X86/weak_resolution_single.ll
@@ -0,0 +1,9 @@
+; RUN: opt -module-summary %s -o %t.bc
+; RUN: llvm-lto -thinlto-action=thinlink -o %t2.bc %t.bc
+
+; RUN: llvm-lto -thinlto-action=promote %t.bc -thinlto-index=%t2.bc -exported-symbol=foo -o - | llvm-lto -thinlto-action=internalize -thinlto-module-id=%t.bc - -thinlto-index=%t2.bc -exported-symbol=foo -o - | llvm-dis -o - | FileCheck %s
+
+; CHECK: define weak_odr void @foo()
+define linkonce_odr void @foo() {
+  ret void
+}
Index: lib/LTO/LTO.cpp
===================================================================
--- lib/LTO/LTO.cpp
+++ lib/LTO/LTO.cpp
@@ -82,10 +82,6 @@
         isPrevailing,
     function_ref<void(StringRef, GlobalValue::GUID, GlobalValue::LinkageTypes)>
         recordNewLinkage) {
-  if (Index.modulePaths().size() == 1)
-    // Nothing to do if we don't have multiple modules
-    return;
-
   // We won't optimize the globals that are referenced by an alias for now
   // Ideally we should turn the alias into a global and duplicate the definition
   // when needed.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D21917.62991.patch
Type: text/x-patch
Size: 1196 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160706/cbcf9ae7/attachment.bin>