[PATCH] D21894: [ELF] - Fixed incorrect logic of version assignments when mixing wildcards with values matching.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits.


================
Comment at: ELF/SymbolTable.cpp:599
@@ +598,3 @@
+        warning("duplicate symbol " + Name + " in version script");
+      B->symbol()->VersionId = I + 2;
+    }
----------------
You don't have to do this in this patch, but `+ 2` seems too magical and needs to be handled in a better way. I think it is better to add `VersionId` member to `Version` struct and store the version id to that member.

================
Comment at: ELF/SymbolTable.cpp:603
@@ +602,3 @@
+
+  for (size_t I = Config->SymbolVersions.size() - 1; I != (size_t)-1; --I) {
+    Version &V = Config->SymbolVersions[I];
----------------
  I >= 0


http://reviews.llvm.org/D21894