[PATCH] D22015: [ELF] Introduce a flag to parse response file according to windows rules

[Davide Italiano via llvm-commits]

davide added inline comments.

================
Comment at: ELF/DriverUtils.cpp:71-75
@@ -56,2 +70,7 @@
   unsigned MissingCount;
+  SmallVector<const char *, 256> Vec(Argv.data(), Argv.data() + Argv.size());
+
+  // We need to get the quoting style for response files before parsing all options,
+  // so we parse here before and ignore all the options but --rsp-quoting.
+  opt::InputArgList Args = this->ParseArgs(Vec, MissingIndex, MissingCount);
 
----------------
ruiu wrote:
> Please move this code inside getQuotingStyle.
This requires duplicating the declaration of `MissingIndex`, `MissingCount`, `Vec` and making `getQuotingStyle a member function or passing `this` to the function. I think it's not a very good compromise.


http://reviews.llvm.org/D22015