[PATCH] D21890: [ELF] - Do not error out when version declaration not found when building executable.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Config.h:104
@@ -103,2 +103,3 @@
   bool Verbose;
+  bool VersionScript = false;
   bool VersionScriptGlobalByDefault = true;
----------------
Rename HasVersionScript

================
Comment at: ELF/SymbolTable.cpp:194
@@ +193,3 @@
+  // In this case we just create new version.
+  if (!Config->Shared && !Config->VersionScript) {
+    Config->SymbolVersions.push_back(elf::Version(Version));
----------------
grimar wrote:
> ruiu wrote:
> > Is `!Config->VersionScript` the same as `Config->SymbolVersions.empty()`?
> Not anymore. Because of next line:
> 
> ```
>  Config->SymbolVersions.push_back(elf::Version(Version));
> ```
> 
> So since we can create a new version now during SymbolTable<ELFT>::insert(), it is not the same.
I'm not still convinced why this condition is not `if (!Config->HasVersionScript)`. I do understand that you are just implementing the PR, but I think you need to justify the PR.


http://reviews.llvm.org/D21890