[PATCH] D22015: [ELF] Introduce a flag to parse response file according to windows rules
Rafael Ávila de Espíndola via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 6 11:48:34 PDT 2016
rafael added inline comments.
================
Comment at: ELF/Config.h:62
@@ -61,2 +61,3 @@
llvm::StringRef OutputFile;
+ llvm::StringRef RspQuoting;
llvm::StringRef SoName;
----------------
Why do you need this to be in Config.h? It is only used in one function, no?
================
Comment at: ELF/DriverUtils.cpp:68
@@ +67,3 @@
+ Config->RspQuoting =
+ (Triple(sys::getProcessTriple()).getOS() == Triple::Win32) ? "windows"
+ : "posix";
----------------
you can drop the ().
http://reviews.llvm.org/D22015
More information about the llvm-commits
mailing list