[PATCH] D21561: [IPRA] Set callee saved registers to none for local function when IPRA is enabled.

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.

================
Comment at: include/llvm/Target/TargetFrameLowering.h:350
@@ +349,3 @@
+              return false;
+        }
+
----------------
vivekvpandya wrote:
> mehdi_amini wrote:
> > mehdi_amini wrote:
> > > Why not looking at the users of F?
> > Why has this been marked as done?
> Changes have been done on local machine, just waiting for your decision on if UseIPRA to be in TargetPassConfig.h or not?
Please mark as done when the revision is updated, otherwise it makes it harder to track.

================
Comment at: test/CodeGen/X86/ipra-local-linkage.ll:19
@@ +18,3 @@
+define void @bar() #0 {
+  %X = add i32 1, 3
+  call void asm sideeffect "movl  %r12d, $0", "{r15}~{r12}"(i32 %X) #0
----------------
vivekvpandya wrote:
> mehdi_amini wrote:
> > vivekvpandya wrote:
> > > mehdi_amini wrote:
> > > > Take %X by argument?
> > > Do you mean as reference?
> > I mean as a function parameter, unless I'm missing why an addition is needed here.
> Yes addition is not needed I can change load constant value to variable X.
Why do you need a load? Why don't you take X as a function parameter (you haven't address this question...)


http://reviews.llvm.org/D21561