[PATCH] D22008: GlobalISel: implement low-level type suitable for MachineInstr selection

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 10:05:29 PDT 2016


On 5 July 2016 at 14:43, Quentin Colombet <qcolombet at apple.com> wrote:
>> I suppose we could add some concept of a generic MachineInstr's "realm" (int/float) to provide the dropped info?
>
> Yeah, that is what I was going to say, the generic code will know if something is floating point or int. That’s probably something we will need at some point elsewhere and we could have that live as a query function like isPreISelOpcode.

If we really think we're going to need that information then I'm not
sure stripping the types down to just a size is the right path after
all. We're going to run into the same ambiguity as for the types
themselves where each operand can have a separate domain (e.g. sitofp,
intrinsics again).

At that point we'd essentially just have the type distributed across 2
tables rather than in one place.

Tim.


More information about the llvm-commits mailing list