[PATCH] D21526: [codeview] Improved array type support (multi dimension array)

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 6 08:44:12 PDT 2016


rnk added a comment.

Looks good after sharing common code


================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1005
@@ +1004,3 @@
+         BaseType->getTag() != dwarf::DW_TAG_rvalue_reference_type);
+
+  return getBaseTypeSizeInBits(BaseType);
----------------
Oh, then let's move it to the common base class for both, DebugHandlerBase.


http://reviews.llvm.org/D21526





More information about the llvm-commits mailing list