[PATCH] D21613: [DSE] Avoid iterator invalidation bugs.

[Chad Rosier via llvm-commits]

mcrosier marked 4 inline comments as done.

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:822
@@ -814,3 +821,3 @@
     if (CallInst *F = isFreeCall(Inst, TLI)) {
       MadeChange |= handleFree(F, AA, MD, DT, TLI);
       continue;
----------------
eli.friedman wrote:
> BBI doesn't point at the free instruction here.
Ah, right.  Should be fixed now.

================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:922
@@ -923,3 +921,3 @@
           // Delete the store and now-dead instructions that feed it.
-          deleteDeadInstruction(DepWrite, *MD, *TLI);
+          deleteDeadInstruction(DepWrite, &BBI, *MD, *TLI);
           ++NumFastStores;
----------------
Fixed.


http://reviews.llvm.org/D21613