[PATCH] D22044: [X86] Support of no_caller_saved_registers attribute (LLVM part)

[Amjad Aboud via llvm-commits]

aaboud added inline comments.

================
Comment at: test/CodeGen/X86/x86-32-intrcc.ll:60
@@ -59,9 +59,3 @@
   ; CHECK-LABEL: test_isr_clobbers
-  ; CHECK-SSE-NEXT: pushl %ebp
-  ; CHECK-SSE-NEXT: pushl %ebx
-  ; CHECK-SSE-NEXT; pushl %eax
-  ; CHECK-SSE-NEXT: popl %eax
-  ; CHECK-SSE-NEXT: popl %ebx
-  ; CHECK-SSE-NEXT: popl %ebp
-  ; CHECK-SSE-NEXT: addl $4, %esp
-  ; CHECK-SSE-NEXT: iretl
+  ; CHECK: pushl %ebp
+  ; CHECK: pushl %ebx
----------------
I will commit this change in a separate commit as it is not related to no_caller_saved_register attribute.
But it is related to X86 interrupt handler calling convention.

This test was written incorrect and the below lines were ignored by FileCheck.

================
Comment at: test/CodeGen/X86/x86-64-intrcc.ll:60
@@ -59,13 +59,3 @@
   ; CHECK-LABEL: test_isr_clobbers
-  ; CHECK-SSE-NEXT: pushq %rax
-  ; CHECK-SSE-NEXT; pushq %r11
-  ; CHECK-SSE-NEXT: pushq %rbp
-  ; CHECK-SSE-NEXT: pushq %rbx
-  ; CHECK-SSE-NEXT: movaps %xmm0
-  ; CHECK-SSE-NEXT: movaps %xmm0
-  ; CHECK-SSE-NEXT: popq %rbx
-  ; CHECK-SSE-NEXT: popq %rbp
-  ; CHECK-SSE-NEXT: popq %r11
-  ; CHECK-SSE-NEXT: popq %rax
-  ; CHECK-SSE-NEXT: addq $8, %rsp
-  ; CHECK-SSE-NEXT: iretq
+  ; CHECK: pushq %rax
+  ; CHECK: pushq %rbp
----------------
I will commit this change in a separate commit as it is not related to no_caller_saved_register attribute.
But it is related to X86 interrupt handler calling convention.

This test was written incorrect and the below lines were ignored by FileCheck.


http://reviews.llvm.org/D22044