[PATCH] D21982: WIP: Implement a per-thread inmemory log

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 21:47:11 PDT 2016


dberris added inline comments.

================
Comment at: lib/xray/xray_inmemory_log.cc:111
@@ +110,3 @@
+    }
+    printf("XRay: Log file in '%s'\n", TmpFilename);
+    return Fd;
----------------
mehdi_amini wrote:
> This looks like debugging, is it intended to be here? 
> Do you really want unconditionally always on? And is stdout the right output?
Yep, this is for debugging. I'm still thinking about how to control this filename either through an API or through environment variables.


http://reviews.llvm.org/D21982





More information about the llvm-commits mailing list