[llvm] r274536 - [mips][ias] Don't break apart and reconstruct StringRef's for k_Token. NFC.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 5 03:10:37 PDT 2016


Author: dsanders
Date: Tue Jul  5 05:10:36 2016
New Revision: 274536

URL: http://llvm.org/viewvc/llvm-project?rev=274536&view=rev
Log:
[mips][ias] Don't break apart and reconstruct StringRef's for k_Token. NFC.

Modified:
    llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp

Modified: llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp?rev=274536&r1=274535&r2=274536&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp (original)
+++ llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp Tue Jul  5 05:10:36 2016
@@ -599,8 +599,7 @@ private:
   MipsAsmParser &AsmParser;
 
   struct Token {
-    const char *Data;
-    unsigned Length;
+    StringRef Str;
   };
 
   struct PhysRegOp {
@@ -1166,7 +1165,7 @@ public:
 
   StringRef getToken() const {
     assert(Kind == k_Token && "Invalid access!");
-    return StringRef(Tok.Data, Tok.Length);
+    return Tok.Str;
   }
   bool isRegPair() const {
     return Kind == k_RegPair && RegIdx.Index <= 30;
@@ -1220,8 +1219,7 @@ public:
   static std::unique_ptr<MipsOperand> CreateToken(StringRef Str, SMLoc S,
                                                   MipsAsmParser &Parser) {
     auto Op = make_unique<MipsOperand>(k_Token, Parser);
-    Op->Tok.Data = Str.data();
-    Op->Tok.Length = Str.size();
+    Op->Tok.Str = Str;
     Op->StartLoc = S;
     Op->EndLoc = S;
     return Op;
@@ -1437,7 +1435,7 @@ public:
       OS << "RegIdx<" << RegIdx.Index << ":" << RegIdx.Kind << ">";
       break;
     case k_Token:
-      OS << Tok.Data;
+      OS << Tok.Str;
       break;
     case k_RegList:
       OS << "RegList< ";




More information about the llvm-commits mailing list