[PATCH] COFFObjectFile imports fix for compressed binaries

[David Majnemer via llvm-commits]

On Mon, Jul 4, 2016 at 2:10 PM, Bandzi Michal <xbandz00 at stud.fit.vutbr.cz>
wrote:

> Unless I made some logical error I can't see, it should work that way,
> doesn't it?
>
> if (lookupTable)
>   return func(lookupTable, ...)
> return func(addressTable, ...)


I was trying to suggest that we ignore the lookup table case and just do:
  return func(addressTable, ...)


>
>
> I wonder if we should just rely on the ImportAddressTableRVA instead of
>> first trying to use the ImportLookupTableRVA.
>>
>> What are your thoughts?
>>
>> On Mon, Jul 4, 2016 at 11:05 AM, Bandzi Michal <
>> xbandz00 at stud.fit.vutbr.cz>
>> wrote:
>>
>> Cituji David Majnemer <david.majnemer at gmail.com>:
>>>
>>> Please clang-format the changes in your patch.
>>>
>>>>
>>>>
>>> Not sure what exactly this means. Found and used this:
>>> http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting
>>> then created a new patch
>>>
>>> Also, LLVM does not use else after a return:
>>>
>>>> http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return
>>>>
>>>>
>>> Hope this is better. New patch as attachement.
>>>
>>>
>>>
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160704/9a5f97d0/attachment.html>