[PATCH] COFFObjectFile imports fix for compressed binaries

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 4 13:43:40 PDT 2016


I wonder if we should just rely on the ImportAddressTableRVA instead of
first trying to use the ImportLookupTableRVA.

What are your thoughts?

On Mon, Jul 4, 2016 at 11:05 AM, Bandzi Michal <xbandz00 at stud.fit.vutbr.cz>
wrote:

> Cituji David Majnemer <david.majnemer at gmail.com>:
>
> Please clang-format the changes in your patch.
>>
>
> Not sure what exactly this means. Found and used this:
> http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting
> then created a new patch
>
> Also, LLVM does not use else after a return:
>> http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return
>>
>
> Hope this is better. New patch as attachement.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160704/5808bb6d/attachment.html>


More information about the llvm-commits mailing list