[PATCH] D21503: [llvm-dwarfdump] - Teach dwarfdump to dump gdb-index section.

[Davide Italiano via llvm-commits]

davide added inline comments.

================
Comment at: include/llvm/DebugInfo/DWARF/DWARFGdbIndex.h:64
@@ +63,2 @@
+
+#endif
----------------
Missing // LLVM_LIB_DEBUGINFO_DWARFGDBINDEX_H

================
Comment at: lib/DebugInfo/DWARF/DWARFGdbIndex.cpp:99
@@ +98,3 @@
+  if (Version != 7) {
+    ErrMessage = "only version 7 is supported for dumping";
+    return;
----------------
Same, "only dumping of version 7 is supported"

================
Comment at: lib/DebugInfo/DWARF/DWARFGdbIndex.cpp:123
@@ +122,3 @@
+  if (CuTypesListSize != 0) {
+    ErrMessage = "CU types list are not supported for dumping";
+    return;
----------------
A better error message would be "Dumping of CU types list is not supported"


http://reviews.llvm.org/D21503