[PATCH] D21954: [PM] Add some internal options for testing out the new PM.

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: include/clang/Driver/CC1Options.td:160
@@ -159,1 +159,3 @@
 
+def newpm_passes_EQ : Joined<["-"], "newpm-passes=">,
+  HelpText<"Pass pipeline description for new PM">;
----------------
Why not removing 'new' ?  Eventually newpm will become pm anyway.

================
Comment at: include/clang/Driver/CC1Options.td:162-163
@@ +161,4 @@
+  HelpText<"Pass pipeline description for new PM">;
+def newpm_aa_pipeline_EQ : Joined<["-"], "newpm-aa-pipeline=">,
+  HelpText<"Alias analysis pipeline for the new PM">;
+
----------------
same here

================
Comment at: lib/CodeGen/BackendUtil.cpp:753
@@ -746,1 +752,3 @@
 
+  if (!CodeGenOpts.NewPMPasses.empty()) {
+    // Use the new PM for the middle end.
----------------
Outline this into its own helper method ?


http://reviews.llvm.org/D21954