[llvm] r274457 - PR28400: Partly undo r274440 to bring test-suite back to life with the new PM
Sean Silva via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 2 20:35:06 PDT 2016
Author: silvas
Date: Sat Jul 2 22:35:06 2016
New Revision: 274457
URL: http://llvm.org/viewvc/llvm-project?rev=274457&view=rev
Log:
PR28400: Partly undo r274440 to bring test-suite back to life with the new PM
PR28400 seems to be not an isolated issue, but a general problem related
to caching analyses. We will need to discuss on llvm-dev.
A test case is in the PR.
Modified:
llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp
Modified: llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp?rev=274457&r1=274456&r2=274457&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp Sat Jul 2 22:35:06 2016
@@ -151,7 +151,8 @@ PreservedAnalyses JumpThreadingPass::run
if (!Changed)
return PreservedAnalyses::all();
PreservedAnalyses PA;
- PA.preserve<LazyValueAnalysis>();
+ // FIXME: Not preserving LVI! We need it to be invalidated so that we
+ // don't run into issues like PR28400. Is there a better solution?
PA.preserve<GlobalsAA>();
return PA;
}
More information about the llvm-commits
mailing list