[polly] r274427 - CodegenCleanup: Drop CFLAA pass from codegen cleanup sequence

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 2 00:58:14 PDT 2016


Author: grosser
Date: Sat Jul  2 02:58:13 2016
New Revision: 274427

URL: http://llvm.org/viewvc/llvm-project?rev=274427&view=rev
Log:
CodegenCleanup: Drop CFLAA pass from codegen cleanup sequence

Since r274197 -polly-position=before-vectorizer caused various LNT failures
for example in SingleSource/Benchmarks/Linpack. These failures seem to only
occur when the CFLAA pass is scheduled in our codegen-cleanup passes, which
suggests that the way we call this AA pass is somehow problematic.  As this pass
is not of high importance, we drop the pass for now to prevent these failures
from happening. At a later point, we might investigate more in-depth why this
specific usage scenario caused correctness issues.

Modified:
    polly/trunk/lib/CodeGen/CodegenCleanup.cpp

Modified: polly/trunk/lib/CodeGen/CodegenCleanup.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/CodegenCleanup.cpp?rev=274427&r1=274426&r2=274427&view=diff
==============================================================================
--- polly/trunk/lib/CodeGen/CodegenCleanup.cpp (original)
+++ polly/trunk/lib/CodeGen/CodegenCleanup.cpp Sat Jul  2 02:58:13 2016
@@ -49,7 +49,6 @@ public:
     // TODO: How to make parent passes discoverable?
     // TODO: Should be sensitive to compiler options in PassManagerBuilder, to
     // which wo do not have access here.
-    FPM->add(createCFLAAWrapperPass());
     FPM->add(createScopedNoAliasAAWrapperPass());
     FPM->add(createTypeBasedAAWrapperPass());
     FPM->add(createAAResultsWrapperPass());




More information about the llvm-commits mailing list