[PATCH] D21930: [ELF] - Implement extern "c++" version script tag

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 2 01:03:31 PDT 2016


ruiu added a comment.

The new code seems to be a copy of the existing code with a small change to demangle symbols. Can you make it smaller?


================
Comment at: ELF/SymbolTable.cpp:564
@@ -563,4 +563,3 @@
 
-// This function processes the --version-script option by marking all global
-// symbols with the VersionScriptGlobal flag, which acts as a filter on the
-// dynamic symbol table.
+static std::string demangleCpp(StringRef Name) {
+#if !defined(HAVE_CXXABI_H)
----------------
We already have `elf::demangle` function.


http://reviews.llvm.org/D21930





More information about the llvm-commits mailing list