[PATCH] D21890: [ELF] - Do not error out when version declaration not found when building executable.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 23:39:21 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/SymbolTable.cpp:194
@@ +193,3 @@
+  // In this case we just create new version.
+  if (!Config->Shared && !Config->VersionScript) {
+    Config->SymbolVersions.push_back(elf::Version(Version));
----------------
Is `!Config->VersionScript` the same as `Config->SymbolVersions.empty()`?


http://reviews.llvm.org/D21890





More information about the llvm-commits mailing list