[llvm] r273919 - Fixed crash of SLP Vectorizer on KNL

[Quentin Colombet via llvm-commits]

Hi Elena,

> On Jun 27, 2016, at 1:07 PM, Elena Demikhovsky via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: delena
> Date: Mon Jun 27 15:07:00 2016
> New Revision: 273919
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=273919&view=rev
> Log:
> Fixed crash of SLP Vectorizer on KNL
> 
> The bug is connected to vector GEPs.
> https://llvm.org/bugs/show_bug.cgi?id=28313
> 
> 
> Added:
>    llvm/trunk/test/Transforms/SLPVectorizer/X86/crash_knl.ll
> Modified:
>    llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp
> 
> Modified: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=273919&r1=273918&r2=273919&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (original)
> +++ llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp Mon Jun 27 15:07:00 2016
> @@ -3765,6 +3765,8 @@ void SLPVectorizerPass::collectSeedInstr
>         continue;
>       if (!isValidElementType(Idx->getType()))
>         continue;
> +      if (GEP->getType()->isVectorTy())
> +        continue;
>       GEPs[GetUnderlyingObject(GEP->getPointerOperand(), *DL)].push_back(GEP);
>     }
>   }
> 
> Added: llvm/trunk/test/Transforms/SLPVectorizer/X86/crash_knl.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/SLPVectorizer/X86/crash_knl.ll?rev=273919&view=auto
> ==============================================================================
> --- llvm/trunk/test/Transforms/SLPVectorizer/X86/crash_knl.ll (added)
> +++ llvm/trunk/test/Transforms/SLPVectorizer/X86/crash_knl.ll Mon Jun 27 15:07:00 2016

Put a more descriptive name for the file. Like gep-knl.ll?

> @@ -0,0 +1,17 @@
> +;RUN: opt < %s -slp-vectorizer -S

Please add check lines to make sure we generate something sane. (Even if that means in this case we do not do anything!)

Also add a comment explaining what is this test checking.

> +
> +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
> +target triple = "x86_64-unknown-linux-gnu"
> +
> +; Function Attrs: noreturn readonly uwtable
> +define void @_Z3fn1v(i32 %x, <16 x i32*>%y) local_unnamed_addr #0 {
> +entry:
> +  %conv42.le = sext i32 %x to i64
> +  %conv36109.le = zext i32 2 to i64
> +  %VectorGep = getelementptr i32, <16 x i32*> %y, i64 %conv36109.le
> +  %VectorGep208 = getelementptr i32, <16 x i32*> %y, i64 %conv42.le
> +  unreachable
> +}
> +
> +attributes #0 = { noreturn readonly uwtable "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="knl" "target-features"="+adx,+aes,+avx,+avx2,+avx512cd,+avx512er,+avx512f,+avx512pf,+bmi,+bmi2,+cx16,+f16c,+fma,+fsgsbase,+fxsr,+lzcnt,+mmx,+movbe,+pclmul,+popcnt,+prefetchwt1,+rdrnd,+rdseed,+rtm,+sse,+sse2,+sse3,+sse4.1,+sse4.2,+ssse3,+x87,+xsave,+xsaveopt" "unsafe-fp-math"="false" "use-soft-float"="false" }
> +
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits