[PATCH] D21033: Add runtime support for __cpu_model (__builtin_cpu_supports)

[Eric Christopher via llvm-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

I agree that we should add the support here. I understand Joerg's wish for a better API, but for drop in compatibility with libgcc we should still define these and perhaps conditionally compile them if we get a better library interface in the future (i.e. compatibility or not).

Thanks a lot for doing this!

-eric

ps One inline request before you commit, thanks. :)


================
Comment at: lib/builtins/cpu_model.c:122
@@ +121,3 @@
+
+static bool isCpuIdSupported() {
+#if defined(i386) || defined(__i386__)
----------------
Please add a block comment above this that spells out that we took it from lib/Support/Host.cpp.


http://reviews.llvm.org/D21033