[PATCH] D21939: Emit CodeView type records for nested classes
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 1 15:49:42 PDT 2016
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: test/DebugInfo/COFF/types-nested-class.ll:28
@@ +27,3 @@
+; CHECK: FieldList (0x1001) {
+; CHECK: TypeLeafKind: LF_FIELDLIST (0x1203)
+; CHECK: }
----------------
amccarth wrote:
> rnk wrote:
> > We should see a NestedType record in A's FieldList. Right now both A and A::Nested are empty, so they share the same field list. :)
> OK, that surprises me, but OK. I wouldn't have expected a type in the field list.
Yeah, I would've called it "member" list, but I was trying to stay closer to their terminology.
http://reviews.llvm.org/D21939
More information about the llvm-commits
mailing list