[PATCH] D21917: ThinLTO: Remove check for multiple modules before applying weak resolutions.

[Peter Collingbourne via llvm-commits]

pcc added a comment.

> If there is an exported symbol, then presumably we are linking with another bitcode module (the importing module).


I mean exported in the sense of "not internalized". This applies in the case where the symbol is used by the native module, in which case we need to make sure we export it here.

> libLTO is handling this differently by adding to llvm.compiler.used, for the same reason as mentioned in another review: linkonce -> weak is (was?) pessimizing codegen on MachO.


Okay, but I'm sure you don't just want this to happen in the case where there is a single ThinLTO module. As the test I am adding in http://reviews.llvm.org/D21915 shows, we are already upgrading to weak.


http://reviews.llvm.org/D21917