[PATCH] D21926: [ARM] Honour ABI for rem under -O0 for EABI, GNUEABI, Android and Musl

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 05:58:57 PDT 2016


rengolin added inline comments.

================
Comment at: test/CodeGen/ARM/divmod-eabi.ll:20
@@ -19,3 +26,1 @@
 ; EABI: __aeabi_idivmod
-; EABI: mov [[div:r[0-9]+]], r0
-; EABI: mov [[rem:r[0-9]+]], r1
----------------
Removing the ABI registers will make the test a lot weaker and PR28164 tells me that this can already be broken in some cases.

Can you expand on what happens to the registers and why the test fails? My gut feeling is that a CHECK-DAG could fix the problem, but worst case scenario, we'll need two sets of CHECKs for O0 and O1.


http://reviews.llvm.org/D21926





More information about the llvm-commits mailing list