[PATCH] D21894: [ELF] - Fixed incorrect logic of version assignments when mixing wildcards with values matching.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/SymbolTable.cpp:565-566
@@ -563,1 +564,4 @@
 
+template <class ELFT>
+void SymbolTable<ELFT>::applySymbolVersion(VersionSymbol &Sym, size_t Version) {
+  std::vector<SymbolBody *> Syms = findAll(Sym.Name, !Sym.HasWildcard);
----------------
ruiu wrote:
> This function should probably be inlined to the place where you call it because non-wildcard patterns and wildcard patterns shares less code. For example, you don't need to call `findAll` for non-wildcards (but instead you want to call `find`). You don't want to issue a warning if non-wildcards. So this function is not actually common code for both cases.
Done.


http://reviews.llvm.org/D21894