[PATCH] D21894: [ELF] - Fixed incorrect logic of version assignments when mixing wildcards with values matching.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Config.h:40
@@ +39,3 @@
+  llvm::StringRef Name;
+  bool HasWildcard;
+};
----------------
ruiu wrote:
> grimar wrote:
> > ruiu wrote:
> > > I think it's not worth to store this property as a member of this variable. You can always compute it from `Name` when needed.
> > Idea here was to avoid several searches of "*?". Since I do 2 iterations now,
> > one for wildcarded names and one for not.
> > 
> > Also I planned to use this struct to add the flag
> > IsExternCpp or something for externs handling patch.
> Yes, I understand that, but finding "*?" is pretty cheap, and number of symbols in version scripts is not that large.
Ok. 
So relative to possible patch for externs:
What about possible list of extern c++ symbols ? Do you suggest to make a separate array for them ?


http://reviews.llvm.org/D21894