[PATCH] D21894: [ELF] - Fixed incorrect logic of version assignments when mixing wildcards with values matching.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 1 02:36:04 PDT 2016
grimar added inline comments.
================
Comment at: ELF/Config.h:40
@@ +39,3 @@
+ llvm::StringRef Name;
+ bool HasWildcard;
+};
----------------
ruiu wrote:
> I think it's not worth to store this property as a member of this variable. You can always compute it from `Name` when needed.
Idea here was to avoid several searches of "*?". Since I do 2 iterations now,
one for wildcarded names and one for not.
Also I planned to use this struct to add the flag
IsExternCpp or something for externs handling patch.
http://reviews.llvm.org/D21894
More information about the llvm-commits
mailing list