[PATCH] D21890: [ELF] - Do not error out when version declaration not found when building executable.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 02:30:18 PDT 2016


grimar added inline comments.

================
Comment at: ELF/SymbolTable.cpp:190
@@ +189,3 @@
+
+  // If we are not building shared it is not an error to
+  // have no version, since version script can absent.
----------------
ruiu wrote:
> I don't see a reason to handle shared libraries in a different way than executables. It feels to me that the correct behavior is printing out the error message if a symbol contains '@' and a version script is given.
Problem of PR28359 is that executable is linked and version script is **not **given.


http://reviews.llvm.org/D21890





More information about the llvm-commits mailing list