[PATCH] D21888: [ELF] - Depricate version references.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

I still half-believe that the va_next is completely ignored, but if so, this patch makes sense. Let's land this to see if this will work.


================
Comment at: ELF/SymbolListFile.cpp:98-99
@@ -97,2 +97,4 @@
   expect("}");
+  // Parent name is not really important for versioning.
+  // We treat this as a depricated feature and just skip it.
   if (!Version.empty() && peek() != ";")
----------------
Add a blank line before the comment. Also I'd mention that parent name is a hint for human that the runtime completely ignores.

  // Each version may have a parent version. For example, "Ver2" defined as
  // "Ver2 { global: foo; local: *; } Ver1;" has "Ver1" as a parent. This version
  // hierarchy is, probably against your instinct, purely for human; the runtime
  // doesn't care about them at all. In LLD, we simply skip the token.


http://reviews.llvm.org/D21888