[PATCH] D21692: [DAGCombiner] Fix visitSTORE to continue processing current SDNode, if findBetterNeighborChains doesn't actually CombineTo it.

[Tim Shen via llvm-commits]

On Thu, Jun 30, 2016 at 4:18 PM Justin Bogner <mail at justinbogner.com> wrote:

> I find this new API very confusing, and the addition you've made to the
> comment doesn't even mention what happens with Chain.
>
> Wouldn't it make more sense to update Chain outside of
> findBetterNeighbourChains anyway?


Done. Part of the reason I included the Chain into findBetterNeighbourChains is
that the caller doesn't have to remember to update the chain (similar to
SelectionDAG::getStore, etc). But I don't have strong opinion on this.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160630/11117ebd/attachment-0001.html>