[PATCH] D18226: Codegen: Tail-duplicate during placement.

[Eric Christopher via llvm-commits]

echristo added a comment.

Couple of inline comments. I think some of the overall design can be separated out and be made a bit simpler - especially as relates to ForcedLayoutPred etc, but we can worry about that as a cleanup that'll happen next.

Thanks!

-eric


================
Comment at: lib/CodeGen/BranchFolding.cpp:641
@@ -638,2 +640,3 @@
   // heuristics.
+  // This is broken, as it breaks tail-dup then merge.
   unsigned EffectiveTailLen = CommonTailLen;
----------------
Can you elaborate here? Perhaps with a FIXME or a TODO.

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:1696
@@ +1695,3 @@
+  if (TailDupPlacement)
+    TailDup.initMF(MF, MMI, MBPI);
+
----------------
The MachineFunction has an MMI so you don't need this argument. :)


http://reviews.llvm.org/D18226