[PATCH] D18762: Rewrite Aggressive Dead Code Elimination

[Chandler Carruth via llvm-commits]

chandlerc added a subscriber: chandlerc.
chandlerc added a comment.

In http://reviews.llvm.org/D18762#471336, @david2050 wrote:

> Following Chandler's feedback, modified to simply replace the existing
>  ADCE rather than having two implementations. Reused baseline names.
>
> Fixed some bugs in handling debug scopes/operations.


Unfortunately, the way this patch is structured, it just shows you deleting the entire ADCE patch, and then adding a new one with no way to tell what the history is. This makes reviewing it really challenging.

I think the best way to go about this is to post small, incremental cleanups and refactorings to the existing ADCE pass until there is a clean design where you can submit a patch that adds control flow deletion (or whatever other logic you want) to the *existing* pass behind a flag.

Does that make sense?


http://reviews.llvm.org/D18762