[PATCH] D21900: [compiler-rt] Fix sanitizer memory allocator on win64.

[Chris Hamilton via llvm-commits]

chrisha added a comment.

In http://reviews.llvm.org/D21900#471571, @rnk wrote:

> In http://reviews.llvm.org/D21900#471537, @etienneb wrote:
>
> > chrisha@ prosposed that we implement an other flavor of MMap to remap memory previously created with NoAccess.
>
>
> I like this better. I think if we try to hard to pretend we have mmap we will eventually go crazy.


I think we should really build a table of the various memory concepts on Posix/Windows, and how they map to each other. And then build an abstract set of memory management functions that provides clean concepts across platforms.

(Without sitting down and trying it, I'm not sure that's possible or desirable in the long run.)


http://reviews.llvm.org/D21900