[PATCH] D19501: Add LoadStoreVectorizer pass

[Alina Sbirlea via llvm-commits]

asbirlea added inline comments.

================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:390
@@ +389,3 @@
+      // first load in the chain).
+      if (isa<StoreInst>(V) && isa<LoadInst>(VV) && VVIdx < VIdx)
+        continue;
----------------
arsenm wrote:
> asbirlea wrote:
> > As loads are inserted at the location of the last load, either invert sign (VVIdx > VIdx) and update comment, or fix load insert location.
> > The former misses vectorization opportunities, but it avoids (at least some of the) incorrect code generation.
> Are you going to fix this / do you have test cases for this and below?
Yes. I have an updated version of the current patch that fixes this and adds couple of unit tests.


http://reviews.llvm.org/D19501