[PATCH] D21892: Clang modules builds depend header-wise on it as they ship all headers from the umbrella folders.

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 30 09:39:37 PDT 2016


beanz added a comment.

Module and non-module builds *are* different, and it sounds like they have different dependencies. Applying the intrinsics_gen dependency liberally around like your patch was doing will severely hurt build parallelism of non-module builds because it will force the intrinsics_gen bottleneck on more components. That is very undesirable to people not using modules.

If the best solution here is to add intrinsics_gen to LLVM_COMMON_DEPENDS, it should only be done if modules are being used. You also shouldn't need to remove all the optional_deps references from the CMakelists files because CMake should unique the dependencies, so duplicates will have no adverse impact.


http://reviews.llvm.org/D21892





More information about the llvm-commits mailing list