[PATCH] D21892: Clang modules builds depend header-wise on it as they ship all headers from the umbrella folders.

[Chris Bieneman via llvm-commits]

beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.

This patch adds a whole bunch of dependencies on intrinsics_gen that don't need to be there. I think you're approaching this problem from the wrong perspective.

In CMake you don't want to dictate the build order as much as the dependencies. You want the target build system (ninja, make, ...) to handle the order around the dependencies.

I'm not familiar with how module builds work, but it sounds to me like the module build needs to depend on intrinsics_gen, as opposed to what your patch does, which makes *everything* depend on intrinsics_gen.


http://reviews.llvm.org/D21892