[PATCH] D21888: [ELF] - Depricate version references.

[George Rimar via llvm-commits]

grimar added a comment.



In http://reviews.llvm.org/D21888#471119, @ruiu wrote:

> Is this really what we want? Let's say we have two version definitions as shown below.
>
>   VER1 { global: foo; local: *; };
>   VER2 { global: bar; } VER1;
>   
>
> In this case, I think VER1's catch-all `local: *` hides all symbols but `foo` and `bar` from VER2. Your patch seems to change this behavior.


There is no difference. Just re-checked with gold.

  VER1 { global: foo; local: *; };
  VER2 { global: bar; } VER1;

and

  VER1 { global: foo; local: *; };
  VER2 { global: bar; };

has the same output. Actually I noticed that much earlier when worked on all of that, but I was sure that hierarchies are required
for correctnes to comform specification. 
But if Drepper writes that there is no point to have it then why not remove it.


http://reviews.llvm.org/D21888