[PATCH] D21866: [ADT] Add a new data structure for managing a priority worklist where re-insertion of entries into the worklist moves them to the end.

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 17:11:25 PDT 2016


sanjoy accepted this revision.
sanjoy added a reviewer: sanjoy.
sanjoy added a comment.

lgtm too


================
Comment at: include/llvm/ADT/PriorityWorklist.h:41
@@ +40,3 @@
+/// ignored. It is an error to insert such a value, and popping elements will
+/// never produce such a value. It is expected to be used with common nullable
+/// types like pointers or optionals.
----------------
ok

================
Comment at: include/llvm/ADT/PriorityWorklist.h:178
@@ +177,3 @@
+  ///
+  /// This predicate wraps a predicate suitable for use with std::remove_if to
+  /// call M.erase(x) on each element which is slated for removal. This just
----------------
Given that there are tests, I'm fine with this.


http://reviews.llvm.org/D21866





More information about the llvm-commits mailing list