[PATCH] D21809: [SystemZ] Add support for .insn and .word/.short/.long/.quad directives

[Zhan Jun Liau via llvm-commits]

zhanjunl added a comment.

Once I figure out if we're sticking with this implementation, I'll continue working on this and fix up all the comments that have been made. Thanks for the quick and thorough review guys!


================
Comment at: test/MC/SystemZ/directive-insn.s:4
@@ +3,3 @@
+
+# TODO: No recognized E, RIE, RRF, SS, SSE, SSF, RSE, RSI instructions.
+
----------------
uweigand wrote:
> We really should have tests for all the formats, since they encode differently.
> 
> I do in fact see instructions already recognized for several of these:
> RIE: CRJ*, RxSBG, ...
> RRF: CRT*, LOCR(G), PPA, many FP insns
> SS: MVC, NC, OC, XC, CLC
> RSE: SRLG etc, LMG/STMG, ...
> 
> For the others, it might be good to add some instructions in those formats, they can be useful for inline asm anyway.
Similar to the comment I added, rie corresponds with RIE-d instructions, of which I couldn't find any that clang supported.

Same with rrf (RRF-a,b), ss (SS-d), rse (I couldn't find an actual format that matched this class, as those instructions are RSY?).


http://reviews.llvm.org/D21809