[PATCH] D21817: [compiler-rt] Fix Sanitizer-common Unittests on win64

[Etienne Bergeron via llvm-commits]

etienneb added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_platform.h:171
@@ -170,3 +170,3 @@
 #ifndef SANITIZER_CAN_USE_ALLOCATOR64
-# if defined(__mips64) || defined(__aarch64__)
+# if defined(__mips64) || defined(__aarch64__) || defined(_WIN32)
 #  define SANITIZER_CAN_USE_ALLOCATOR64 0
----------------
rnk wrote:
> `|| SANITIZER_WINDOWS` instead. Can you add comments about why we can't use the 64-bit allocator on win64 yet?
I'll remove this fix for now.
The unittests are still broken on windows, but I better fix is coming.

================
Comment at: lib/sanitizer_common/tests/sanitizer_test_main.cc:17
@@ +16,3 @@
+#ifdef _MSC_VER
+#pragma comment(linker, "/STACK:33554432")
+#endif
----------------
rnk wrote:
> Which tests fail without this? 20MB seems like too much.
```
TEST(BVGraph, BasicTest) {
  BasicTest<BV1>();
  BasicTest<BV2>();
  BasicTest<BV3>();
  BasicTest<BV4>();
}
```

It's only failing on 64-bits.


http://reviews.llvm.org/D21817