[llvm] r274148 - Don't verify inputs to the Linker if ODR merging.

[Adrian Prantl via llvm-commits]

> On Jun 29, 2016, at 11:31 AM, Rafael Espindola via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: rafael
> Date: Wed Jun 29 13:31:48 2016
> New Revision: 274148
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=274148&view=rev
> Log:
> Don't verify inputs to the Linker if ODR merging.
> 
> This fixes pr28072.
> 
> The point, as Duncan pointed out, is that the file is already
> partially linked by just reading it.
> 
> Long term I think the solution is to make metadata owned by the module
> and then the linker will lazily read it and be in charge of all the
> linking. Running a verifier in each input will defeat the lazy
> loading, but will be legal.
> 
> Right now we are at the unfortunate position that to support odr
> merging we cannot verify the inputs, which mildly annoying (see test
> update).

Does this mean the final Module will never be verified? In r268965, I added support for dropping invalid debug info (as caught by the verifier) in LTO to allow us to make the Verifier stricter in the future while still being able to compile bitcode produced by older versions of clang and I'm worried that this might break now.

-- adrian