[PATCH] D21791: [InstCombine] Fix for trunc folding build break

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 11:34:47 PDT 2016


sanjoy requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: lib/Transforms/InstCombine/InstCombineCasts.cpp:592
@@ +591,3 @@
+    // with the value we're folding the trunc to (in case of a race).
+    if (!LI->isVolatile() && (!LI->isAtomic() || LI->hasOneUse()))
+      if (Value *AvailableVal = FindAvailableLoadedValue(
----------------
Don't we have to check if `LI` is at most unordered?  I realize I missed this the last time.

Please also add a test case.



Repository:
  rL LLVM

http://reviews.llvm.org/D21791





More information about the llvm-commits mailing list