[PATCH] D21813: ARM: Fix ARMSubtarget for WOA

[mmediouni via llvm-commits]

my123 added a subscriber: my123.
my123 added a comment.

> It should be changed, as Thumb-2 code is generated after this. With NoARM=true, no JIT code is generated at all


if you didn't see my NoARM comment.

Thumb-2 code is generated anyway, or at least code that fully runs on both 8.0 and 8.1, Fibonnaci is stable even with high test values, which even means that __chkstk works fine.


================
Comment at: lib/Target/ARM/ARMSubtarget.cpp:216
@@ -215,3 +212,2 @@
-
   if (isAAPCS_ABI())
     stackAlignment = 8;
----------------
compnerd wrote:
> Windows ARM NT is a pure thumb-2 environment.  We really should not be generating ARM code.  I dont think that this should be changed.
It should be changed, as Thumb-2 code is generated after this. With NoARM=true, no JIT code is generated at all


http://reviews.llvm.org/D21813