[PATCH] D21794: [ELF] - Added support for --unresolved-symbols option.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with the following changes.


================
Comment at: ELF/Config.h:36
@@ -35,1 +35,3 @@
 
+enum class HandlingRule { NoUndef, Error, Warn, Ignore };
+
----------------
This name is too generic. I'd rename `UnresolvedPolicy`.

================
Comment at: ELF/Options.td:154
@@ +153,3 @@
+def unresolved_symbols: J<"unresolved-symbols=">,
+  HelpText<"Determine how to handle unresolved symbols.">;
+
----------------
Remove `.`.

================
Comment at: ELF/Writer.cpp:281-282
@@ -281,2 +280,4 @@
+
+  if (Config->UnresolvedSymbols != HandlingRule::NoUndef)
     if (Config->Shared && Sym->symbol()->Visibility == STV_DEFAULT)
       return;
----------------
  if (Config->Shared && Sym->symbol()->Visitility == STV_DEFAULT &&
      Config->UnresolvedSymbols != HandlingRule::NoUndef)


http://reviews.llvm.org/D21794