[PATCH] D21809: [SystemZ] Add support for .insn and .word/.short/.long/.quad directives

Marcin Koƛcielnicki via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 29 01:04:31 PDT 2016


koriakin added inline comments.

================
Comment at: lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp:900
@@ +899,3 @@
+    return ParseDirectiveInsn(DirectiveID.getLoc());
+  else if (IDVal == ".short" || IDVal == ".word")
+    return ParseDirectiveWord(2, DirectiveID.getLoc());
----------------
koriakin wrote:
> .short, .long. .quad are already supported by common code.
Also, .word would be better implemented by using addAliasForDirective instead of reimplementing the handler.


http://reviews.llvm.org/D21809





More information about the llvm-commits mailing list