[PATCH] D21794: [ELF] - Added support for --unresolved-symbols option.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Writer.cpp:734
@@ +733,3 @@
+template <class ELFT>
+static void reportUndefinedFromSharedLibs(SymbolTable<ELFT> &Symtab) {
+  // In lld we do not report about undefines in DSO, so
----------------
grimar wrote:
> ruiu wrote:
> > We don't want to do this -- we don't care whether undefined symbols in DSOs are resolved or not unlike GNU linkers.
> Generally yes, but I was thinking about this option as about the only option that can show this information in lld.
> That was key feature of this option for me.
> 
> Shouldn't we show warning then ? For example when IgnoreInObjectFiles is used explicitly we probably want to inform user that
> it does not do what is expected from documentation ? (does not show eerors for symbols from DSO).
We don't care about undefined symbols in DSOs because we think identifying them doesn't make sense. So, I think we don't want to provide an option to detect an "error" that doesn't make sense to us.


http://reviews.llvm.org/D21794