[PATCH] D21721: Object: Replace NewArchiveIterator with a simpler NewArchiveMember class. NFCI.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 22:11:44 PDT 2016


pcc added inline comments.

================
Comment at: include/llvm/Object/ArchiveWriter.h:25
@@ +24,3 @@
+  std::unique_ptr<MemoryBuffer> Buf;
+  sys::TimeValue ModTime = sys::TimeValue::PosixZeroTime();
+  unsigned UID = 0, GID = 0, Perms = 0644;
----------------
rafael wrote:
> Getting the time in here seems really odd. 
Hm? This is the (constant) epoch, not the current time.


http://reviews.llvm.org/D21721





More information about the llvm-commits mailing list