[PATCH] D21732: [ELF] Initial support for wildcard in symbol versions

[Rui Ueyama via llvm-commits]

ruiu added a comment.

Stylistic comments.


================
Comment at: ELF/LinkerScript.cpp:292
@@ -293,3 +291,3 @@
 // mark ('?') matches one character.
-static bool matchStr(StringRef S, StringRef T) {
+bool lld::elf::matchStr(StringRef S, StringRef T) {
   for (;;) {
----------------
I think you can remove `lld::`.

================
Comment at: ELF/LinkerScript.h:99
@@ -98,1 +98,3 @@
 
+bool matchStr(StringRef S, StringRef T);
+
----------------
Please move this line at beginning of this elf {} namespace.

================
Comment at: ELF/SymbolTable.cpp:462
@@ +461,3 @@
+std::vector<SymbolBody *> SymbolTable<ELFT>::findAll(StringRef Pattern) {
+  std::vector<SymbolBody *> Result;
+
----------------
Naturally you want to move this line after the `if`.


http://reviews.llvm.org/D21732