[PATCH] D21775: [InstCombine] Simplify and correct folding fcmps with the same children

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 28 19:00:09 PDT 2016


On Tue, Jun 28, 2016 at 6:40 PM Eric Christopher <echristo at gmail.com> wrote:

> Be nice to be able to split out the NFC testcase changes from the ones
> that matter if you can.
>

I may misunderstood the "NFC testcase changes". Let me clarify. There are 3
kinds of changes:
1) there are a few re-naming changes that seem to be introduced by
utils/update_test_checks.py, but I don't quite understand why. I used the
same version of update_test_checks.py.
2) bug fixes, from line 2586 to line 2643.
3) the rest, constant foldings.

1) is NFC; 2) is not NFC; 3) depends. But I don't know how to split these 3
kinds of changes. Previously I was explaining why splitting 2) and 3) is
hard, but now I still have no clue why 1) happened.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160629/6a91628f/attachment.html>


More information about the llvm-commits mailing list